Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/16098
  
    I see, so the writer should be closed before committing?
    
    Can the writer be closed before aborting too? 
    In that case, maybe it's cleaner to use nested try-finally? an inner 
try-finally manages closing the writer, and the outer try-catch commits or 
aborts.
    
    But this is reasonable too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to