Github user liancheng commented on the pull request:

    https://github.com/apache/spark/pull/2241#issuecomment-54384096
  
    One concern related to Hive Thrift server and CLI support. Currently we're 
using some ugly reflection hacks to hook into Hive because related Hive code 
was not designed to be extensible for such scenarios 
([here](https://github.com/apache/spark/blob/f2b5b619a9efee91573c0e546792e68e72afce21/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala#L85-L95),
 
[here](https://github.com/apache/spark/blob/f2b5b619a9efee91573c0e546792e68e72afce21/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIService.scala#L63-L73)
 and 
[here](https://github.com/apache/spark/blob/f2b5b619a9efee91573c0e546792e68e72afce21/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLSessionManager.scala#L35-L48)).
 These hacks are brittle and highly depends on specific Hive implementation. 
Currently I don't have any thorough plan for this, but this should definitely 
be taken into account.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to