Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16020#discussion_r90599078
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -334,10 +334,10 @@ class KMeans @Since("1.5.0") (
val summary = new KMeansSummary(
model.transform(dataset), $(predictionCol), $(featuresCol), $(k))
model.setSummary(Some(summary))
- instr.logSuccess(model)
if (handlePersistence) {
instances.unpersist()
}
+ instr.logSuccess(model)
--- End diff --
The `handlePersistence` check in `KMeans` at L309 should also be updated to
use `dataset.storageLevel`. Since we're touching KMeans here anyway we may as
well do it now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
