Github user MLnick commented on the issue:

    https://github.com/apache/spark/pull/16037
  
    I'm sure this will be net positive, and _shouldn't_ cause any regression. 
Still, we must be certain. @AnthonyTruchet can you provide for posterity the 
detailed test results for the vector sizes you mentioned? And perhaps also some 
results for some smaller sizes (since I imagine the benefit of this change for 
that scenario is quite small and we should just check there is no unexpected 
overhead or regression we've somehow missed from the `toDense` calls though I 
can't see that happening).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to