Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/16082#discussion_r90672608 --- Diff: python/setup.py --- @@ -69,10 +69,15 @@ EXAMPLES_PATH = os.path.join(SPARK_HOME, "examples/src/main/python") SCRIPTS_PATH = os.path.join(SPARK_HOME, "bin") +DATA_PATH = os.path.join(SPARK_HOME, "data") SCRIPTS_TARGET = os.path.join(TEMP_PATH, "bin") JARS_TARGET = os.path.join(TEMP_PATH, "jars") EXAMPLES_TARGET = os.path.join(TEMP_PATH, "examples") +DATA_TARGET = os.path.join(TEMP_PATH, "data") +LICENSES_PATH = os.path.join(SPARK_HOME, "licenses") +LICENSES_TARGET = os.path.join(TEMP_PATH, "licenses") +data_files = glob.glob(os.path.join(LICENSES_PATH, "*")) --- End diff -- Oh no I mean, including the license files is reasonable its more is it necessary to use `data_files` here (and down bellow) when all of the other packages we are producing simply use `package_data` to specify the backing files.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org