Github user brkyvz commented on the issue:
https://github.com/apache/spark/pull/16030
That is something I tried to standardize. I think we should standardize it,
otherwise it is very confusing. I think it's the right thing to do. I just
don't want people's production jobs failing in weird ways.
On Dec 2, 2016 10:18 PM, "Takeshi Yamamuro" <notificati...@github.com>
wrote:
> *@maropu* commented on this pull request.
> ------------------------------
>
> In sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/
> OrcPartitionDiscoverySuite.scala
> <https://github.com/apache/spark/pull/16030>:
>
> > @@ -146,7 +146,7 @@ class OrcPartitionDiscoverySuite extends QueryTest
with TestHiveSingleton with B
> i <- 1 to 10
> pi <- Seq(1, 2)
> ps <- Seq("foo", "bar")
> - } yield Row(i, pi, i.toString, ps))
> + } yield Row(i, i.toString, pi, ps))
>
> It seems moving partition columns into the end is a correct behaviour by
> referring comments here: https://github.com/apache/
> spark/blame/master/sql/core/src/test/scala/org/apache/spark/sql/test/
> DataFrameReaderWriterSuite.scala#L590. Anything I miss?
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/spark/pull/16030>, or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AFACe0Z95AZx8FzaiY3g4iWvazmrm0f2ks5rEQnIgaJpZM4K9gFA>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
