Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16114#discussion_r90756702
  
    --- Diff: 
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisRecordProcessor.scala
 ---
    @@ -56,6 +56,27 @@ private[kinesis] class 
KinesisRecordProcessor[T](receiver: KinesisReceiver[T], w
         logInfo(s"Initialized workerId $workerId with shardId $shardId")
       }
     
    +  private def addRecords(batch: List[Record], checkpointer: 
IRecordProcessorCheckpointer): Unit = {
    +    receiver.addRecords(shardId, batch)
    +    logDebug(s"Stored: Worker $workerId stored ${batch.size} records for 
shardId $shardId")
    +    receiver.setCheckpointer(shardId, checkpointer)
    --- End diff --
    
    BTW is this supposed to be called on every batch or once at the end? I 
don't know how it works.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to