Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/16133#discussion_r90771895
--- Diff: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala ---
@@ -132,54 +132,57 @@ class NewHadoopRDD[K, V](
override def compute(theSplit: Partition, context: TaskContext):
InterruptibleIterator[(K, V)] = {
val iter = new Iterator[(K, V)] {
- val split = theSplit.asInstanceOf[NewHadoopPartition]
+ private val split = theSplit.asInstanceOf[NewHadoopPartition]
logInfo("Input split: " + split.serializableHadoopSplit)
- val conf = getConf
+ private val conf = getConf
- val inputMetrics = context.taskMetrics().inputMetrics
- val existingBytesRead = inputMetrics.bytesRead
+ private val inputMetrics = context.taskMetrics().inputMetrics
+ private val existingBytesRead = inputMetrics.bytesRead
// Sets the thread local variable for the file's name
--- End diff --
nit. Updating comment together?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
