Github user anabranch commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16138#discussion_r90785863
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
    @@ -2661,12 +2661,30 @@ object functions {
       def unix_timestamp(s: Column, p: String): Column = withExpr 
{UnixTimestamp(s.expr, Literal(p)) }
     
       /**
    +    * Convert time string with given pattern
    +    * (see 
[http://docs.oracle.com/javase/tutorial/i18n/format/simpleDateFormat.html])
    +    * to Unix time stamp (in seconds), return null if fail.
    +    * @group datetime_funcs
    +    * @since 1.5.0
    +    */
    +  def to_timestamp(s: Column, p: String): Column = withExpr 
{UnixTimestamp(s.expr, Literal(p)) }
    --- End diff --
    
    still missing a cast here...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to