Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/16014#discussion_r90792416
--- Diff: R/check-cran.sh ---
@@ -82,4 +83,20 @@ else
# This will run tests and/or build vignettes, and require SPARK_HOME
SPARK_HOME="${SPARK_HOME}" "$R_SCRIPT_PATH/"R CMD check
$CRAN_CHECK_OPTIONS SparkR_"$VERSION".tar.gz
fi
+
+# Install source package to get it to generate vignettes rds files, etc.
+if [ -n "$CLEAN_INSTALL" ]
--- End diff --
So it looks like we lost the knitted HTML files in the SparkR package with
this change. FWIW this may not be bad as the html files are not usually used
locally and only used for the website and I think the docs creation part of the
build should pick that up. (Verifying that now)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
