Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16131#discussion_r90944278
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
 ---
    @@ -505,7 +505,7 @@ object GeneralizedLinearRegression extends 
DefaultParamsReadable[GeneralizedLine
         override def initialize(y: Double, weight: Double): Double = {
           require(y >= 0.0, "The response variable of Poisson family " +
             s"should be non-negative, but got $y")
    -      y
    +      y + 0.1
    --- End diff --
    
    OK that makes some sense but I'm not seeing why 0.1 is added in all cases. 
Why isn't the solution to make this the minimum or something? I understand 
"that's how R does it" but wondering why that makes sense.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to