Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/16158#discussion_r90970832
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/TrainValidationSplit.scala ---
@@ -226,6 +230,29 @@ class TrainValidationSplitModel private[ml] (
@Since("2.0.0")
override def write: MLWriter = new
TrainValidationSplitModel.TrainValidationSplitModelWriter(this)
+
+ private var trainingSummary: Option[TuningSummary] = None
+
+ private[tuning] def setSummary(summary: Option[TuningSummary]):
this.type = {
+ this.trainingSummary = summary
+ this
+ }
+
+ /**
+ * Return true if there exists summary of model.
+ */
+ @Since("2.0.0")
+ def hasSummary: Boolean = trainingSummary.nonEmpty
+
+ /**
+ * Gets summary of model on training set. An exception is
+ * thrown if `trainingSummary == None`.
+ */
+ @Since("2.0.0")
+ def summary: TuningSummary = trainingSummary.getOrElse {
+ throw new SparkException(
+ s"No training summary available for the
${this.getClass.getSimpleName}")
+ }
--- End diff --
I'm thinking we should add a new trait to wrap the summary-related code. I
can create another jira if that's reasonable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
