GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/16169
[SPARK-18326][SPARKR][ML] Review SparkR ML wrappers API for 2.1
## What changes were proposed in this pull request?
Reviewing SparkR ML wrappers API for 2.1 release, mainly issues include:
* Remove ```probabilityCol``` from the argument list of ```spark.logit```
and ```spark.randomForest```. Since it was used when making prediction and
should be an argument of ```predict```, and we will work on this at
[SPARK-18618](https://issues.apache.org/jira/browse/SPARK-18618) in the next
release cycle.
* Fix ```spark.als``` params should be consistent with MLlib.
## How was this patch tested?
Existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanboliang/spark spark-18326
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16169.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16169
----
commit a5c3b8b77d7736ca2f8e2a957dd202cdcfaf732a
Author: Yanbo Liang <yblia...@gmail.com>
Date: 2016-12-06T10:07:22Z
Review SparkR ML wrappers API for 2.1
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
