Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16137#discussion_r91169287
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -670,10 +677,14 @@ class SparkContext(config: SparkConf) extends Logging
{
* sc.cancelJobGroup("some_job_to_cancel")
* }}}
*
- * If interruptOnCancel is set to true for the job group, then job
cancellation will result
- * in Thread.interrupt() being called on the job's executor threads.
This is useful to help ensure
- * that the tasks are actually stopped in a timely manner, but is off by
default due to HDFS-1208,
- * where HDFS may respond to Thread.interrupt() by marking nodes as dead.
+ * @param groupId job group's identification
+ * @param description job group's decription
--- End diff --
The `interruptOnCancel` doc makes sense but these don't say much beyond the
name. I'd expand them or remove them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
