Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16165#discussion_r91221480
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -546,7 +546,7 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
val appsToRetain = new mutable.LinkedHashMap[String,
FsApplicationHistoryInfo]()
def shouldClean(attempt: FsApplicationAttemptInfo): Boolean = {
- now - attempt.lastUpdated > maxAge && attempt.completed
+ now - attempt.lastUpdated > maxAge
--- End diff --
BTW changing the entry's `lastUpdated` to be the time the file was last
loaded instead of the mod time of the file on disk is a perfectly valid way of
fixing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
