GitHub user rxin opened a pull request:

    https://github.com/apache/spark/pull/16187

    [SPARK-18760][SQL] Consistent format specification for FileFormats

    ## What changes were proposed in this pull request?
    We currently rely on FileFormat implementations to override toString in 
order to get a proper explain output. It'd be better to just depend on 
shortName for those.
    
    Before:
    ```
    scala> spark.read.text("test.text").explain()
    == Physical Plan ==
    *FileScan text [value#15] Batched: false, Format: 
org.apache.spark.sql.execution.datasources.text.TextFileFormat@xyz, Location: 
InMemoryFileIndex[file:/scratch/rxin/spark/test.text], PartitionFilters: [], 
PushedFilters: [], ReadSchema: struct<value:string>
    ```
    
    After:
    ```
    scala> spark.read.text("test.text").explain()
    == Physical Plan ==
    *FileScan text [value#15] Batched: false, Format: text, Location: 
InMemoryFileIndex[file:/scratch/rxin/spark/test.text], PartitionFilters: [], 
PushedFilters: [], ReadSchema: struct<value:string>
    ```
    
    Also closes #14680.
    
    ## How was this patch tested?
    Verified in spark-shell.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rxin/spark SPARK-18760

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/16187.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16187
    
----
commit 566c8007dcf74594c23ef2b1fcc394ce64029e9b
Author: Reynold Xin <r...@databricks.com>
Date:   2016-12-07T05:22:40Z

    [SPARK-18760][SQL] Consistent format specification for FileFormats

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to