Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/16121#discussion_r91234619
--- Diff: python/pyspark/serializers.py ---
@@ -278,50 +278,51 @@ def __repr__(self):
return "AutoBatchedSerializer(%s)" % self.serializer
-class CartesianDeserializer(FramedSerializer):
+class CartesianDeserializer(Serializer):
"""
Deserializes the JavaRDD cartesian() of two PythonRDDs.
--- End diff --
Maybe we should document this a bit given that we had problems with the
implementation. (e.g. expand on the "Due to batching, we can't use the Java
cartesian method." comment from `rdd.py` to explain how this is intended to
function).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
