Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16175#discussion_r91352281
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -1110,6 +1110,17 @@ class DatasetSuite extends QueryTest with
SharedSQLContext {
}
assert(e.getMessage.contains("Cannot create encoder for Option of
Product type"))
}
+
+
+ test ("SPARK-17460: the sizeInBytes in Statistics shouldn't overflow to
a negative number") {
+ // If the sizeInBytes in Statistics exceeds the limit of an Int,
+ // it should convert to a BigInt instead of overflowing to a negative
number
--- End diff --
How about?
`Since the sizeInBytes in Statistics could exceed the limit of an Int, we
should use BigInt instead of Int for avoiding possible overflow`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
