GitHub user vanzin opened a pull request:

    https://github.com/apache/spark/pull/16200

    [SPARK-18773][core] Make commons-crypto config translation consistent.

    This change moves the logic that translates Spark configuration to
    commons-crypto configuration to the network-common module. It also
    extends TransportConf and ConfigProvider to provide the necessary
    interfaces for the translation to work.
    
    As part of the change, I removed SystemPropertyConfigProvider, which
    was mostly used as an "empty config" in unit tests, and adjusted the
    very few tests that required a specific config.
    
    I also changes the config keys for AES encryption to live under the
    "spark.network." namespace, which is more correct than their previous
    names under "spark.authenticate.".
    
    Tested via existing unit test.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vanzin/spark SPARK-18773

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/16200.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16200
    
----
commit cf32d3c66dc1a29f6a6fcba65e1ea158ed09dcde
Author: Marcelo Vanzin <van...@cloudera.com>
Date:   2016-12-07T22:03:19Z

    [SPARK-18773][core] Make commons-crypto config translation consistent.
    
    This change moves the logic that translates Spark configuration to
    commons-crypto configuration to the network-common module. It also
    extends TransportConf and ConfigProvider to provide the necessary
    interfaces for the translation to work.
    
    As part of the change, I removed SystemPropertyConfigProvider, which
    was mostly used as an "empty config" in unit tests, and adjusted the
    very few tests that required a specific config.
    
    I also changes the config keys for AES encryption to live under the
    "spark.network." namespace, which is more correct than their previous
    names under "spark.authenticate.".
    
    Tested via existing unit test.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to