Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13579#discussion_r91587654
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala ---
@@ -349,6 +349,17 @@ class HistoryServerSuite extends SparkFunSuite with
BeforeAndAfter with Matchers
}
+ /**
+ * Verify that the security manager needed for the history server can be
instantiated
+ * when `spark.authenticate` is `true`, rather than raise an
`IllegalArgumentException`.
+ */
+ test("SecurityManagerStartsWithSecureShuffle") {
--- End diff --
nit: can you write a test description like the others in the class, instead
of this camel-cased string?
Also spark.authenticate is not (just) for secure shuffle, so the string
itself is not really accurate. Just mention spark.authenticate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
