Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16134#discussion_r91839339
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertIntoHiveTableSuite.scala
---
@@ -166,6 +166,30 @@ class InsertIntoHiveTableSuite extends QueryTest with
TestHiveSingleton with Bef
sql("DROP TABLE tmp_table")
}
+ test("Delete the temporary staging directory and files after each
insert") {
+ withTempDir { tmpDir =>
+ withTable("tab") {
+ sql(
+ s"""
+ |CREATE TABLE tab(c1 string)
+ |location '${tmpDir.toURI.toString}'
+ """.stripMargin)
+
+ (1 to 3).map { i =>
+ sql(s"INSERT OVERWRITE TABLE tab SELECT '$i'")
+ }
+ def listFiles(path: File): List[String] = {
+ val dir = path.listFiles()
+ val folders = dir.filter(_.isDirectory).toList
+ val filePaths = dir.map(_.getName).toList
+ filePaths ::: folders.flatMap(listFiles)
--- End diff --
http://www.scala-lang.org/api/2.9.3/scala/collection/immutable/List.html
`:::` is prepend. Let me use `append` here. That should be more common.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
