Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16245#discussion_r91845272
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -514,6 +514,19 @@ case class OptimizeCodegen(conf: CatalystConf) extends
Rule[LogicalPlan] {
/**
+ * Reorders the predicates in `Filter` so more expensive expressions like
UDF can evaluate later.
+ */
+object ReorderPredicatesInFilter extends Rule[LogicalPlan] with
PredicateHelper {
+ def apply(plan: LogicalPlan): LogicalPlan = plan transform {
+ case Filter(pred, child) =>
+ val (deterministicExprs, others) =
splitConjunctivePredicates(pred).reverse
--- End diff --
Yea I see. I only reorder the deterministic expression in the suffix of
predicates.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
