Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/16135#discussion_r91849717
--- Diff:
core/src/main/scala/org/apache/spark/metrics/source/StaticSources.scala ---
@@ -97,6 +97,12 @@ object HiveCatalogMetrics extends Source {
MetricRegistry.name("parallelListingJobCount"))
/**
+ * Tracks the total number of cachedDataSourceTables hits.
+ */
+ val METRIC_DATASOUCE_TABLE_CACHE_HITS = metricRegistry.counter(
+ MetricRegistry.name("dataSourceTableCacheHits"))
--- End diff --
That's kind of odd, I'd expect the duplicate table building to cause more
file accesses or at least cache hits since we are scanning the filesystem
multiple times. Is that not the case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
