Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16258#discussion_r92076810
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQueryStatusAndProgressSuite.scala
---
@@ -38,13 +38,18 @@ class StreamingQueryStatusAndProgressSuite extends
SparkFunSuite {
| "id" : "${testProgress1.id.toString}",
| "runId" : "${testProgress1.runId.toString}",
| "name" : "myName",
- | "timestamp" : "2016-12-05T20:54:20.827Z",
+ | "triggerTimestamp" : "2016-12-05T20:54:20.827Z",
| "numInputRows" : 678,
| "inputRowsPerSecond" : 10.0,
| "durationMs" : {
| "total" : 0
| },
- | "currentWatermark" : 3,
+ | "queryTimestamps" : {
+ | "eventTime.avg" : "2016-12-05T20:54:20.827Z",
--- End diff --
1000 * 5 seconds batch is < 2 hours. Anyways, I think it will be equally
or more confusing adding it later as a top-level field in Progress (e.g.
`timestamp`, `eventTime`, `processingTime` ?). It may be better to have the
top-level `timestamp`, and all other execution level detailed timestamps inside
a single map.
Anyways, I am updating the PR, but I think this is a little short-sighted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
