Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16258#discussion_r92087297
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/EventTimeWatermarkExec.scala
---
@@ -28,24 +26,48 @@ import org.apache.spark.sql.types.MetadataBuilder
import org.apache.spark.unsafe.types.CalendarInterval
import org.apache.spark.util.AccumulatorV2
-/** Tracks the maximum positive long seen. */
-class MaxLong(protected var currentValue: Long = 0)
- extends AccumulatorV2[Long, Long] {
+/** Class for collecting event time stats with an accumulator */
--- End diff --
nit: please document the time unit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
