Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16252#discussion_r92229647
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -694,7 +694,7 @@ private[storage] class PartiallyUnrolledIterator[T](
}
override def next(): T = {
- if (unrolled == null) {
+ if (unrolled == null || !unrolled.hasNext) {
--- End diff --
Yeah that's a fair point because it should be fair to put the burden on the
caller to check `hasNext` before calling `next` and now `TorrentBroadcast` does
that. However, are there other call sites that need that type of fix too? if
all callers are well behaved then I agree we could revert the added `hasNext`
call in `next`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
