GitHub user rxin opened a pull request:
https://github.com/apache/spark/pull/16277
[SPARK-18854][SQL] numberedTreeString and apply(i) inconsistent for
subqueries
## What changes were proposed in this pull request?
This is a bug introduced by subquery handling. numberedTreeString (which
uses generateTreeString under the hood) numbers trees including innerChildren
(used to print subqueries), but apply (which uses getNodeNumbered) ignores
innerChildren. As a result, apply(i) would return the wrong plan node if there
are subqueries.
This patch fixes the bug.
## How was this patch tested?
Added a test case in SubquerySuite.scala to test both the depth-first
traversal of numbering as well as making sure the two methods are consistent.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rxin/spark SPARK-18854
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16277.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16277
----
commit 28113223d0fd623705266599da2c8603eb7e26ab
Author: Reynold Xin <r...@databricks.com>
Date: 2016-12-14T06:52:59Z
[SPARK-18854][SQL] numberedTreeString and apply(i) inconsistent for
subqueries.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
