Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16255#discussion_r92359444
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -200,6 +200,8 @@ object RemoveAliasOnlyProject extends Rule[LogicalPlan]
{
case plan: Project if plan eq proj => plan.child
--- End diff --
it is safe to only replace attributes in the ancestor nodes.
Alias with the same exprId but not the same object, replace the alias with
it's child. it is not safe ,right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
