Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16276#discussion_r92450069
--- Diff: core/src/test/scala/org/apache/spark/rdd/RDDSuite.scala ---
@@ -88,6 +88,13 @@ class RDDSuite extends SparkFunSuite with
SharedSparkContext {
}
}
+ test("flatten") {
+ val nums = sc.makeRDD(Array(Array(1, 2, 3), Array(4, 5), Array(6)), 2)
+ assert(nums.flatten.collect().toList === List(1, 2, 3, 4, 5, 6))
+ val strs = sc.makeRDD(Array(Array("a", "b", "c"), Array("d", "e"),
Array("f")), 2)
+ assert(strs.flatten.collect().toList === List("a", "b", "c", "d", "e",
"f"))
--- End diff --
I don't think it's necessary to test both nums and strings, one would be
fine and you should just move it to the "basic operations" test above and reuse
an RDD if possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
