Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2287#discussion_r17188526
  
    --- Diff: python/pyspark/tests.py ---
    @@ -180,6 +180,22 @@ def tearDown(self):
             self.sc.stop()
             sys.path = self._old_sys_path
     
    +class CloudPickleTestCase(PySparkTestCase):
    +    def SetUp(self):
    --- End diff --
    
    This is capitalized (`SetUp`) so it won't be called by `unittest`.  Also, 
we should just end up inheriting the proper setup and teardown methods from 
PySparkTestCase, so you don't need these methods. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to