Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/16304#discussion_r92753590
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -572,6 +572,10 @@ class Dataset[T] private[sql](
val parsedDelay =
Option(CalendarInterval.fromString("interval " + delayThreshold))
.getOrElse(throw new AnalysisException(s"Unable to parse time
delay '$delayThreshold'"))
+ // Threshold specified in months/years is non-deterministic
--- End diff --
I think waiting 1 month for late data is a reasonable use case. Based on
the definition of the watermark, its actually okay for us to over estimate this
delay too. Why not take take the max (31 days, leap year)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
