Github user ryan-williams commented on the issue:

    https://github.com/apache/spark/pull/16311
  
    > if you make a change, but you don't change any files under the YARN 
module, then some slower YARN tests are skipped by excluding that tag. I don't 
remember exactly what the code does, so it might add the exclusion in more 
cases, but that is the idea at least.
    
    Interesting, where is the code that does this that you referred to? Some 
kind of hard-coded rules about what has to be rebuilt/re-tested when various 
things change?
    
    > It would require some duplication (e.g. version of shared dependencies) 
but is probably doable. Don't know if there are any other implications.
    
    Looking at the spark-tags pom and libraries, it has no dependencies other 
than scalatest (test scope; I had missed changing this from "compile" to "test" 
scope in this PR, just updated, thanks!) which it gets from the root POM.
    
    It does get at least some necessary configuration from the root POM for 
publishing a `test-jar`; if that's all there is, we could duplicate it and 
remove the root-POM inheritance, or we could factor it into a root-root-POM 
that spark-tags and spark-parent inherit from.
    
    Obviously this is all pretty sticky, but while we're here I'm interested in 
at least discussing what the most idiomatic solution would be, whether or not 
we ultimately decide that it's worth the trouble.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to