Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/16319#discussion_r92915632
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala
---
@@ -246,9 +246,9 @@ private[csv] object CSVTypeCast {
} else {
castType match {
case _: ByteType => datum.toByte
- case _: ShortType => datum.toShort
- case _: IntegerType => datum.toInt
- case _: LongType => datum.toLong
+ case _: ShortType => Try(datum.toShort).getOrElse(null)
+ case _: IntegerType => Try(datum.toInt).getOrElse(null)
+ case _: LongType => Try(datum.toLong).getOrElse(null)
--- End diff --
Why do you use `Try` for each type here? In the JIRA, I proposed another
approach (https://github.com/apache/spark/compare/master...maropu:SPARK-18699),
and I think the fix is more natural. Anyway, ISTM we do not decide yet it is
worth fixing this issue...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
