Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r92961639
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -135,6 +146,14 @@ case class Cast(child: Expression, dataType: DataType)
extends UnaryExpression w
override def nullable: Boolean = Cast.forceNullable(child.dataType,
dataType) || child.nullable
+ override def timeZoneResolved: Boolean =
+ (!(childrenResolved && Cast.needTimeZone(child.dataType, dataType)))
|| super.timeZoneResolved
+
+ override lazy val resolved: Boolean =
+ childrenResolved && checkInputDataTypes().isSuccess && timeZoneResolved
+
+ override def withTimeZone(zoneId: String): TimeZoneAwareExpression =
copy(zoneId = zoneId)
--- End diff --
Yes, this is a copy ctor, but the analyzer `ResolveTimeZone` can't call the
copy ctor because it doesn't know the actual expression class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
