Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16290 Generally, it looks good to me. The only concern is the external behavior change. Since Spark 2.0, users are able to get the warehouse location by the following two ways: ```Scala spark.sql("set spark.sql.warehouse.dir").show() ``` ```Scala println(spark.conf.get("spark.sql.warehouse.dir")) ``` After this PR, the output will be `<undefined>`. Do we need extra code changes to fix this? @cloud-fan
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org