Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16296#discussion_r93011311
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -69,16 +69,19 @@ statement
| ALTER DATABASE identifier SET DBPROPERTIES tablePropertyList
#setDatabaseProperties
| DROP DATABASE (IF EXISTS)? identifier (RESTRICT | CASCADE)?
#dropDatabase
| createTableHeader ('(' colTypeList ')')? tableProvider
- (OPTIONS tablePropertyList)?
+ (OPTIONS options=tablePropertyList)?
(PARTITIONED BY partitionColumnNames=identifierList)?
- bucketSpec? (AS? query)?
#createTableUsing
+ bucketSpec?
+ (TBLPROPERTIES properties=tablePropertyList)?
+ (COMMENT comment=STRING)?
--- End diff --
I think it's more natural to write the table definition first, then the
comment, i.e. important things first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
