Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16337 @kevinyu98 this looks like pretty solid work. A couple of questions: - This is a **huge** PR. This will be hard to review. Is there a change that we can split this up in more digestible pieces. - On a related note. Given the size, it might be easy to miss a correctness issue. - Are the tests part of a test kit?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org