Github user dusenberrymw commented on a diff in the pull request: https://github.com/apache/spark/pull/16263#discussion_r93093157 --- Diff: python/pyspark/rdd.py --- @@ -135,12 +135,12 @@ def _load_from_socket(port, serializer): break if not sock: raise Exception("could not open socket") - try: - rf = sock.makefile("rb", 65536) - for item in serializer.load_stream(rf): - yield item - finally: - sock.close() + # The RDD materialization time is unpredicable, if we set a timeout for socket reading + # operation, it will very possibly fail. See SPARK-18281. + sock.settimeout(None) + # The socket will be automatically closed when garbage-collected. + rf = sock.makefile("rb", 65536) + return serializer.load_stream(sock.makefile("rb", 65536)) --- End diff -- Can you remove the `rf = sock.makefile("rb", 65536)` line since it is redundant?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org