Github user mridulm commented on the issue: https://github.com/apache/spark/pull/12775 @kayousterhout As @lirui-intel mentioned above, there are two parts to this change. One is moving handleFailedTask to finally - that is a correct change. The other is catching Throwable, logging it and ignoring it. This is an incorrect practice. Specifically in this context, since it is within Utils.logUncaughtExceptions - the logging issue is already handled.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org