Github user nsyca commented on the issue:

    https://github.com/apache/spark/pull/16337
  
     I have tested a few runs on `SQLQueryTestSuite` to confirm it allows to 
have sub-directories under 
`sql/core/src/test/resources/sql-tests/[inputs|results]` to group test files 
further. By reading the code, I'm pretty sure it supports multi-level 
sub-directories. The only requirement is the name of the file needs to be 
unique globally under inputs/.
    
    With that knowledge, I propose we have this structure under directory 
`sql/core/src/test/resources/sql-tests/[inputs`:
    
    ````
    subquery/
    subquery/in-subquery/
    subquery/in-subquery/simple-in.sql
    subquery/in-subquery/simple-not-in.sql
    subquery/in-subquery/in-group-by.sql (in parent side, subquery, and both)
    subquery/in-subquery/not-in-group-by.sql
    subquery/in-subquery/in-order-by.sql
    subquery/in-subquery/in-limit.sql
    subquery/in-subquery/in-having.sql
    subquery/in-subquery/in-joins.sql
    subquery/in-subquery/not-in-joins.sql
    subquery/in-subquery/in-set-operations.sql
    subquery/in-subquery/in-with-cte.sql
    subquery/in-subquery/not-in-with-cte.sql
    subquery/in-subquery/in-multiple-columns.sql
    …
    subquery/exists-subquery/
    subquery/scalar-subquery/
    ```
    
    Each test file will contain approximately 10-20 test cases. Some of the 
test cases will be able to classified in multiple ways. In that case, the 
tester will use his/her best judgement to classify them, or maybe we can 
entertain the idea of "complex" in the file name (I personally don't like it as 
those terms are subjective. To someone a SQL with a-few-table joins is complex. 
Others may see it not.)
    
    We can run a single test file in `.../inputs` or any sub-directory under it 
with the following command 
    
    `build/sbt "~sql/test-only *SQLQueryTestSuite -- -z <filename>.sql"`
    
    The downside is <filename> needs to be the exact name. It does not allow 
wildcard characters at this point. Perhaps this is something we can enhance in 
the future.
    
    Lastly, we will break up this in-subquery test cases to multiple PRs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to