Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/16375#discussion_r93458753 --- Diff: common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java --- @@ -591,7 +591,11 @@ public void writeToOutputStreamIntArray() throws IOException { // verify that writes work on objects that are not byte arrays final ByteBuffer buffer = StandardCharsets.UTF_8.encode("大åä¸ç"); buffer.position(0); - buffer.order(ByteOrder.LITTLE_ENDIAN); + --- End diff -- Can this just be `buffer.order(ByteOrder.nativeOrder())`? that's what's done elsewhere. CC @NathanHowell for a thought.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org