Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93565567
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -303,14 +341,15 @@ object GeneralizedLinearRegression extends
DefaultParamsReadable[GeneralizedLine
/** Set of family and link pairs that GeneralizedLinearRegression
supports. */
private[regression] lazy val supportedFamilyAndLinkPairs = Set(
- Gaussian -> Identity, Gaussian -> Log, Gaussian -> Inverse,
- Binomial -> Logit, Binomial -> Probit, Binomial -> CLogLog,
- Poisson -> Log, Poisson -> Identity, Poisson -> Sqrt,
- Gamma -> Inverse, Gamma -> Identity, Gamma -> Log
+ "gaussian" -> Identity, "gaussian" -> Log, "gaussian" -> Inverse,
--- End diff --
@yanboliang Could you help me understand the issue caused by using string?
If I use object, then I have to create a Tweedie object that is not used
anywhere else. And also I have to write two methods in `Family`: one returns
the global Tweedie object (where the variancePower is preset) and one returns
the a TweedieFamily object created using the user-specified variancePower. I
hope we are fine using string since there are only a few values.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
