Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16371#discussion_r93677262
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -33,10 +33,9 @@ import org.apache.spark.util.collection.OpenHashMap
* The Percentile aggregate function returns the exact percentile(s) of
numeric column `expr` at
* the given percentage(s) with value range in [0.0, 1.0].
*
- * The operator is bound to the slower sort based aggregation path because
the number of elements
- * and their partial order cannot be determined in advance. Therefore we
have to store all the
- * elements in memory, and that too many elements can cause GC paused and
eventually OutOfMemory
- * Errors.
+ * Because the number of elements and their partial order cannot be
determined in advance.
+ * Therefore we have to store all the elements in memory, and that too
many elements can cause GC
--- End diff --
Could you fix the language? `..., and that too...` That sentence is weird.
This is probably on me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
