Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16383#discussion_r93724370
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -471,23 +471,29 @@ abstract class TypedImperativeAggregate[T] extends
ImperativeAggregate {
def createAggregationBuffer(): T
/**
- * In-place updates the aggregation buffer object with an input row.
buffer = buffer + input.
+ * Updates the aggregation buffer object with an input row and returns a
new buffer object. For
+ * performance, the function may do in-place update and return it
instead of constructing new
--- End diff --
oh. got it. that makes sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
