Github user nsyca commented on a diff in the pull request:
https://github.com/apache/spark/pull/16337#discussion_r93821009
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/in-group-by.sql
---
@@ -0,0 +1,117 @@
+-- A test suite for GROUP BY in parent side, subquery, and both predicate
subquery
+-- It includes correlated cases.
+
+-- tables and data types
+
+CREATE DATABASE indb;
--- End diff --
If there is no explicit restriction, I would like to keep the create
database/use database so that the test file is self-contained and can be run in
different environments with minimal side effect.
I don't have any preference between real tables or temporary views but
variations are good to exercise different code paths. If all the test cases are
written homogeneously to certain patterns, it limits the coverage. Again, if
there is no explicit rules or guidelines on which particular ways to write test
cases, I would like to request to have it kept at this format.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
