Github user itg-abby commented on the issue:

    https://github.com/apache/spark/pull/15496
  
    @holdenk 
    Thanks for the review and your availability, I really appreciate the work 
you are doing too by mentoring me! I didn't realize np.append was making 
copies, though it made a lot of sense once I thought about what is actually 
going on there in terms of memory. 
    
    The appends were also ultimately unnecessary and have been removed in favor 
of a much better, simpler, efficient call to make the csr matrix!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to