GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/16402
[SPARK-18999][SQL][minor] simplify Literal codegen
## What changes were proposed in this pull request?
`Literal` can use `CodegenContex.addReferenceObj` to implement codegen,
instead of `CodegenFallback`. This can also simplify the generated code a
little bit, before we will generate: `((Expression) references[1]).eval(null)`,
now it's just `references[1]`.
## How was this patch tested?
N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloud-fan/spark minor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16402.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16402
----
commit 60108571773d9d196cd491512a5cbcd01d878afa
Author: Wenchen Fan <wenc...@databricks.com>
Date: 2016-12-26T07:22:32Z
simplify Literal codegen
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
