Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r93898562
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -658,6 +720,17 @@ class Analyzer(
Generate(newG.asInstanceOf[Generator], join, outer, qualifier,
output, child)
}
+ // A special case for View, replace the output attributes with the
attributes that have the
+ // same names from the child. If the corresponding attribute is not
found, throw an
+ // AnalysisException.
+ // TODO: Also check the dataTypes and nullabilites of the output.
--- End diff --
Can we also explain why we need to replace output attributes in the code
comment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
