Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16397#discussion_r93960977
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamReaderWriterSuite.scala
 ---
    @@ -535,15 +536,15 @@ class DataStreamReaderWriterSuite extends StreamTest 
with BeforeAndAfter with Pr
     
       test("MemorySink can recover from a checkpoint in Complete Mode") {
         val checkpointLoc = newMetadataDir
    -    val checkpointDir = new File(checkpointLoc, "offsets")
    +    val checkpointDir = new File(new URI(s"$checkpointLoc/offsets"))
    --- End diff --
    
    I don't really have a better idea, but this looked a little funny. A URI 
isn't generally going to be interpreted correctly as a local file path unless 
it happens to not contain a scheme. Does is something like `new 
URI(...).getPath` better?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to