Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15664#discussion_r93999377 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -211,6 +211,52 @@ object JdbcUtils extends Logging { } /** + * Returns the schema if the table already exists in the JDBC database. + */ + def getSchema(conn: Connection, url: String, table: String): Option[StructType] = { + val dialect = JdbcDialects.get(url) + + Try { + val statement = conn.prepareStatement(dialect.getSchemaQuery(table)) + try { + getSchema(statement.executeQuery(), dialect) + } finally { + statement.close() + } + } match { + case Success(v) => + Some(v) + case Failure(e) => + None + } --- End diff -- Please do not use Try/Success/Failure. https://github.com/databricks/scala-style-guide#exception-handling-try-vs-try
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org